Skip to content

[OSS-ONLY]Fix dotnet with pgaudit failure in github actions #4301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanscorpio7 merged 13 commits into from
Dec 15, 2025
Merged

[OSS-ONLY]Fix dotnet with pgaudit failure in github actions #4301

Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
84abcd6
running dotnet with pgaudit to analyse failure, not able to repro in …
pranavJ23 Dec 7, 2025
a15d725
changing the ignored line in pgaudit.c
pranavJ23 Dec 7, 2025
15958b3
running pgaudit with dotnet and jdbc
pranavJ23 Dec 12, 2025
0093e14
setting to run cron job
pranavJ23 Dec 14, 2025
d385368
minor change
pranavJ23 Dec 14, 2025
52083fc
adding patch file
pranavJ23 Dec 15, 2025
19d314d
minor changes
pranavJ23 Dec 15, 2025
cdff656
debugging
pranavJ23 Dec 15, 2025
6416864
changing 5x to pr branch to test
pranavJ23 Dec 15, 2025
02d61a5
testing github WFs
pranavJ23 Dec 15, 2025
321cf29
testing github WFs
pranavJ23 Dec 15, 2025
62d7bdc
testing github WFs
pranavJ23 Dec 15, 2025
a462b52
reverting pgaudit to a cron job
pranavJ23 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/jdbc-tests-pgaudit-enable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ jobs:
git clone --depth 1 --branch REL_17_STABLE https://github.com/pgaudit/pgaudit.git
cd pgaudit
# adding the patch to fix BABEL-4600 to test in Github
sed -i '1517 s/^ else$/ else if (auditEventStack != NULL)/' pgaudit.c
sed -i '1532 s/^ else$/ else if (auditEventStack != NULL)/' pgaudit.c
make install USE_PGXS=1 PG_CONFIG=~/psql/bin/pg_config
Copy link
Copy Markdown
Contributor

@tanscorpio7 tanscorpio7 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mantain a patch file instead and apply it here, this will avoid future failures like this. You can create a patch file per branch.

elif [[ "${{ matrix.extension_branch }}" == 'BABEL_4_X_DEV' ]]; then
git clone --depth 1 --branch REL_16_STABLE https://github.com/pgaudit/pgaudit.git
cd pgaudit
# adding the patch to fix BABEL-4600 to test in Github
sed -i '1452 s/^ else$/ else if (auditEventStack != NULL)/' pgaudit.c
sed -i '1467 s/^ else$/ else if (auditEventStack != NULL)/' pgaudit.c
make install USE_PGXS=1 PG_CONFIG=~/psql/bin/pg_config
else
echo "Unsupported branch: ${{ matrix.extension_branch }}"
Expand Down
Loading