feat: Enhance reloader with dynamic secret tracking and version change handling#579
Draft
thiago-boche wants to merge 2 commits intobank-vaults:mainfrom
Draft
feat: Enhance reloader with dynamic secret tracking and version change handling#579thiago-boche wants to merge 2 commits intobank-vaults:mainfrom
thiago-boche wants to merge 2 commits intobank-vaults:mainfrom
Conversation
thiago-boche
force-pushed
the
feature/dynamicsecrets
branch
from
e898366 to
a259f7f
Compare
…e handling - Introduced dynamic secret lease management in the Controller, allowing for tracking of secret metadata and restart times. - Added methods to handle KV version changes and dynamic secret TTL thresholds for workload restarts. - Implemented concurrency-safe access to workload tracking using sync.RWMutex. - Updated the Vault client initialization to support dynamic secret renewal and version retrieval. - Enhanced tests to cover scenarios for KV version changes, dynamic secret TTL thresholds, and mixed workload decisions. - Refactored secret retrieval logic to return detailed secret information, including dynamic lease data. Signed-off-by: Thiago Boche <38021019+thiago-boche@users.noreply.github.com>
Signed-off-by: Thiago Boche <38021019+thiago-boche@users.noreply.github.com>
thiago-boche
force-pushed
the
feature/dynamicsecrets
branch
from
a259f7f to
f9d437b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Notes for reviewer