-
Notifications
You must be signed in to change notification settings - Fork 110
fix(client): accumulate RPC extension hooks instead of replacing #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
de2ee85 to
3d89130
Compare
danyalprout
reviewed
Jan 14, 2026
danyalprout
requested changes
Jan 14, 2026
Collaborator
danyalprout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me, would like to avoid the dependency loop on client-node though
3d89130 to
fd8618d
Compare
fd8618d to
f168cbb
Compare
Reth's `extend_rpc_modules` and `on_node_started` use a replacement model where each call overwrites the previous hook. This caused only the last extension's hooks to execute, making endpoints like `base_meterBundle` and `base_transactionStatus` unavailable. Introduce `BaseBuilder` wrapper that accumulates hooks in vectors, then applies them all in a single reth call when launching. This maintains the existing extension API while fixing the accumulation issue. Closes #438
f168cbb to
0b68fb2
Compare
danyalprout
approved these changes
Jan 14, 2026
Collaborator
danyalprout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Collaborator
|
@niran we'll need to backport this commit onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BaseBuilderwrapper that accumulatesextend_rpc_modulesandon_node_startedhooks in vectors instead of replacing themTxPoolExtension,MeteringExtension,FlashblocksExtension) to use newadd_rpc_module()andadd_node_started_hook()methodsProblem
Reth's
extend_rpc_modulesandon_node_starteduse a replacement model—each call overwrites the previous hook. This caused only the last extension's hooks to execute, making endpoints likebase_meterBundleandbase_transactionStatusunavailable even when their respective extensions were enabled.Solution
The new
BaseBuilderwrapper collects all hooks during extension setup, then applies them all in a single reth call when launching. This maintains the existing extension API while fixing the accumulation issue.Closes #438
Test plan
cargo test --package base-client-node --features test-utilspassesbase_transactionStatus,base_meterBundle, flashblocks) are accessible when multiple extensions are enabled