Immediate avatar and embed variants#1955
Merged
jorgemanrubia merged 1 commit intomainfrom Dec 7, 2025
Merged
Conversation
jeremy
force-pushed
the
immediate-variants
branch
from
be6f318 to
4fe91c5
Compare
Process variants synchronously on attachment to close the window between image upload and variant availability, guaranteeing that we won't have lazy variant processing attempts in GET requests. Tradeoff is that we do variant processing in upload requests, which is actually desirable. We're working with images that should take milliseconds to resize given that we'll already have the file on hand. References rails/rails#51951
jeremy
force-pushed
the
immediate-variants
branch
from
4fe91c5 to
21f3f72
Compare
flavorjones
approved these changes
Dec 5, 2025
jeremy
pushed a commit
that referenced
this pull request
Dec 8, 2025
lonexw
pushed a commit
to lonexw/kanban
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process variants synchronously on attachment to close the window between image upload and variant availability, guaranteeing that we won't have lazy variant processing attempts in GET requests.
Tradeoff is that we do variant processing in upload requests, which is actually desirable. We're working with images that should take milliseconds to resize given that we'll already have the file on hand.
Note there's a tricky gotcha with when after-commit hooks fire since they're per connection pool. This leads to variant processing occurring at different times for SaaS/non-SaaS due to the replica connection! Hence the change to explicitly create Blobs before attaching them, guaranteeing predictable ordering.
References rails/rails#51951
/cc @flavorjones @dhh @tomrossi7