Fix pio-build signing for forks without secret#3
Merged
basmeerman merged 1 commit intomasterfrom Feb 15, 2026
Merged
Conversation
Secrets cannot be used in if: conditionals for reusable workflows. Use shell-level check for empty secret instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
basmeerman
added a commit
that referenced
this pull request
Mar 19, 2026
Extract STATE_A entry logic (modem reset, error clearing, access teardown) into static evse_enter_state_a() helper. Resolves CodeQL cpp/long-switch alert #3 where the STATE_B1/STATE_A fall-through case exceeded 30 lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use shell-level check instead of if-conditional for signing key availability.