Skip to content

Fix pio-build signing for forks without secret #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basmeerman merged 1 commit into from
Feb 15, 2026
Merged

Fix pio-build signing for forks without secret #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/pio-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,13 @@ jobs:
PLATFORMIO_BUILD_FLAGS='-DVERSION=\"v${{ steps.version.outputs.version }}\" -DDBG=0' pio run -d SmartEVSE-3/
mkdir -p ./SmartEVSE-3/distribution
- name: Sign normal version
if: ${{ secrets.SECRET_RSA_KEY != '' }}
env:
super_secret: ${{ secrets.SECRET_RSA_KEY }}
run: |
if [ -z "$super_secret" ]; then
echo "Signing key not available, skipping firmware signing"
exit 0
fi
secret_file=$(mktemp)
echo "$super_secret" > "$secret_file"
openssl dgst -sign "$secret_file" -keyform PEM -sha256 -out firmware.sign -binary ./SmartEVSE-3/.pio/build/release/firmware.bin
Expand All @@ -97,10 +100,13 @@ jobs:
run: |
PLATFORMIO_BUILD_FLAGS='-DVERSION=\"v${{ steps.version.outputs.version }}\" -DDBG=1' pio run -d SmartEVSE-3/
- name: Sign debug version
if: ${{ secrets.SECRET_RSA_KEY != '' }}
env:
super_secret: ${{ secrets.SECRET_RSA_KEY }}
run: |
if [ -z "$super_secret" ]; then
echo "Signing key not available, skipping firmware signing"
exit 0
fi
secret_file=$(mktemp)
echo "$super_secret" > "$secret_file"
openssl dgst -sign "$secret_file" -keyform PEM -sha256 -out firmware.sign -binary ./SmartEVSE-3/.pio/build/release/firmware.bin
Expand Down
Loading