You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I still maintain that this will potentially break some workflow (after all, the currently published version does use the token for the API requests (https://github.com/bats-core/bats-action/blob/3.0.1/action.yaml#L141), and now it will suddenly stop using it in the new version unless the user takes extra steps, but I think this PR implements the change the way you had suggested.
before this PR the action was using the github token silently, now we are going to make it optional so the user can choose to pass it or not
and now it will suddenly stop using it in the new version unless the user takes extra steps
it will not stop, just it will make api calls not authenticated and subject to rate limits, but it will not hit the common users unless with an high usage of this action each minutes.
In general passing the token as extra step with with: is a common pattern in the most famous and used actions.
Also don't worry I will cut a major release and write it to the release note :)
but I think this PR implements the change the way you had suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still maintain that this will potentially break some workflow (after all, the currently published version does use the token for the API requests (https://github.com/bats-core/bats-action/blob/3.0.1/action.yaml#L141), and now it will suddenly stop using it in the new version unless the user takes extra steps, but I think this PR implements the change the way you had suggested.