Adapter scale and shift #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsKue
added
feature
Contributor
There was a problem hiding this comment.
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
bayesflow/approximators/model_comparison_approximator.py:256
- The tuple unpacking of the classifier_network may lead to issues if the deserialize function does not return an iterable. Consider assigning the output directly and verifying its format.
(config["classifier_network"],) = deserialize(config["classifier_network"], custom_objects=custom_objects)
| def scale(self, keys: str | Sequence[str], by: float | np.ndarray): | ||
| from .transforms import Scale | ||
|
|
||
| self.transforms.append(MapTransform({key: Scale(scale=by) for key in keys})) |
There was a problem hiding this comment.
MapTransform is referenced but not imported. Please add an import statement for MapTransform to ensure it is defined.
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/test_adapters/conftest.py:23
- [nitpick] The key 'x' used for scaling and shifting might be ambiguous; consider using a more descriptive name to improve code clarity.
.scale("x", by=[-1, 2])
bayesflow/adapters/adapter.py:559
- [nitpick] Consider moving the import statements out of the function bodies to the top of the module for consistency and potential performance improvements.
from .transforms import Scale
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #353