Skip to content

Conversation

@vpratz
Copy link
Collaborator

@vpratz vpratz commented Apr 10, 2025

In my opinion, the notebook would benefit from more details, so feel free to add things @LarsKue @stefanradev93.

@vpratz vpratz requested review from LarsKue and stefanradev93 April 10, 2025 14:22
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 8 files with indirect coverage changes

Copy link
Contributor

@LarsKue LarsKue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates. Overall, I think it looks good.

It may be nice if we mentioned that the Adapter is a nicer way to specify what used to be a Configurator previously. Users no longer have to override the whole default pipeline, and we provide a lot of functionality users can piece together as they like instead of simply having to give us one big function that does everything.

There is also a typo: "convencient".

@vpratz
Copy link
Collaborator Author

vpratz commented Apr 12, 2025

Thanks a lot for the proof-reading. I have added a short comment on the configurator, to make the connection clearer, but feel free to extend.

@vpratz vpratz merged commit fcdaae3 into bayesflow-org:main Apr 12, 2025
14 checks passed
@vpratz vpratz deleted the updated-v1-to-v2-notebook branch April 12, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants