Skip to content

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Sep 5, 2024

The bazel inventory for this sphinxdocs is in #2188.

Removed the things that are definitely not used and the rest of the symbols
can be left until we become bzlmod only - they do not require much maintenance.

The bazel inventory for this sphinxdocs is in bazel-contrib#2188.

Removed the things that are definitely not used and the rest of the symbols
can be left until we become bzlmod only - they do not require much maintenance.
@aignas aignas requested a review from rickeylev as a code owner September 5, 2024 13:46
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the doc comment, otherwise lgtm

python_register_multi_toolchains = _python_register_multi_toolchains
python_register_toolchains = _python_register_toolchains

# Useful for documentation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. not intended to be public? Lets put a more explicit comment saying its only here for documentation, not public consumption, then.

@aignas aignas enabled auto-merge September 6, 2024 02:08
@aignas aignas added this pull request to the merge queue Sep 6, 2024
Merged via the queue into bazel-contrib:main with commit 53f7407 Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants