fix: pass extra_pip_args to parse_requirements
#2254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Seems like some of the builds are failing and I'm not sure if I'll have time to fix them on the fork. Assuming people approve of this change, I'm happy for someone else to apply it outside of this PR. |
|
Fixed by #2258 so will close this one. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
Before this PR we were just dropping the `extra_pip_args` passed to `pip.parse` and were just using the args passed through the requirements file. Thanks to @swarren12 for pointing this out. This PR also passes `extra_pip_args` to `sdist` `whl_library` instances so that users can build the `sdists` correctly when using `experimental_index_url` feature. Summary: - pass `extra_pip_args` when building sdists in experimental mode - join `extra_pip_args` from the file and the pip.parse attr - test: add a test to ensure that the extra args are joined Fixes #2239 Closes #2254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #2239.
The
extra_pip_argsvariable was not being correctly passed toparse_requirements(), causing further calls to ignore anything that was set here.This was a problem if, for example, the
--trusted-hostargument was needed to talk to the index set byexperimental_index_url.