Skip to content

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Sep 27, 2024

Before this PR we were just dropping the extra_pip_args passed to
pip.parse and were just using the args passed through the requirements
file. Thanks to @swarren12 for pointing this out.

This PR also passes extra_pip_args to sdist whl_library instances
so that users can build the sdists correctly when using
experimental_index_url feature.

Summary:

  • pass extra_pip_args when building sdists in experimental mode
  • join extra_pip_args from the file and the pip.parse attr
  • test: add a test to ensure that the extra args are joined

Fixes #2239
Closes #2254

@rickeylev rickeylev added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 3, 2024
@aignas aignas added this pull request to the merge queue Oct 3, 2024
Merged via the queue into bazel-contrib:main with commit 4f38119 Oct 3, 2024
4 checks passed
@aignas aignas deleted the fix/sdist-extra-pip-args branch October 7, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extra_pip_args do not seem to be passed to whl_library

2 participants