fix(toolchain): no chmod on windows when downloading hermetic toolchain #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code would not chmod for the Windows hermetic toolchains because there is usually no need - Windows does not have chmod and if you are downloading the Windows repo on a UNIX system, you won't run it, so it will stay as is. However, that left a single case where somebody may want to download the Linux toolchain on a Windows and the main cases are: * `bazel sync` * build a docker image on Windows using `rules_oci` or similar. Fixes bazel-contrib#2660
rickeylev
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code would not chmod for the Windows hermetic toolchains
because there is usually no need - Windows does not have chmod and if
you are downloading the Windows repo on a UNIX system, you won't run it,
so it will stay as is.
However, that left a single case where somebody may want to download the
Linux toolchain on a Windows and the main cases are:
bazel syncrules_ocior similar.Fixes #2660