Skip to content

fix(toolchain): no chmod on windows when downloading hermetic toolchain #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged

fix(toolchain): no chmod on windows when downloading hermetic toolchain #2693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ Unreleased changes template.

{#v0-0-0-fixed}
### Fixed
* Nothing fixed.
* Do not try to run `chmod` when downloading non-windows hermetic toolchain
repositories on Windows. Fixes
[#2660](https://github.com/bazel-contrib/rules_python/issues/2660).

{#v0-0-0-added}
### Added
Expand Down
4 changes: 3 additions & 1 deletion python/private/python_repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ def _python_repository_impl(rctx):
# pycs being generated at runtime:
# * The pycs are not deterministic (they contain timestamps)
# * Multiple processes trying to write the same pycs can result in errors.
if "windows" not in platform:
#
# Note, when on Windows the `chmod` may not work
if "windows" not in platform and "windows" != repo_utils.get_platforms_os_name(rctx):
repo_utils.execute_checked(
rctx,
op = "python_repository.MakeReadOnly",
Expand Down