-
-
Notifications
You must be signed in to change notification settings - Fork 639
fix(rules): make py_console_script_binary compatible with symbolic macros
#3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aignas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
- Is there any way we can add a test for this?
- Could you please add a
CHANGELOG.mdnote to let people know that this fixes an issue?
c91459a to
d3d11ba
Compare
|
@aignas thank you for your review! sure, i am looking into it ATM. in the dev-guide i read that integration tests are discuraged. in c91459a i quickly tried to add a simpler build test, however that failed in CI, presumably because bazel 7 doesnt support symbolic macros. so do you think in this case it would be okay to add a new integration test and ignore (if possible) bazel 7 tests there? |
|
re: testing this: Is adding target_compatible_with sufficient? Or does bazel 7 failure before it that is processed? If TCW isn't checked early enough, then how about wrapping it in a legacy macro, then checking the bazel version there, and skiping early? There's utility target in rules_testing for generating a no-op skip target for such cases; see skip_test in tests/py_runtime_pair/py_runtime_pair_tests.bzl for an example re: losing the underscore prefix: We'll just have to live with it. We could add an infix or suffix to help denote its internal. e.g. |
py_console_script_binary compatible with symbolic macrospy_console_script_binary compatible with symbolic macros
Fixes target naming to follow symbolic macro conventions introduced in Bazel 8.0.