Skip to content

Conversation

comius
Copy link
Contributor

@comius comius commented Aug 26, 2025

This removes the support for Bazel "extra actions".

These have been long deprecated and little to no usage. Because of how long they've
been deprecated, their lack of use, and how long their replacement (aspects) has
been available, this is not being considered a breaking change.

Fixes bazelbuild/bazel#16455
Fixes #3215

@rickeylev
Copy link
Collaborator

@comius : Are extra actions present in Bazel 7 or Bazel 8?

@aignas : I'm inclined to not call this a breaking change. I don't think the extra action stuff was really used externally; even within Google it only had a handful of cases. Thoughts?

Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for not calling it a breaking change.

@rickeylev rickeylev changed the title cleanup!: remove support for extra actions cleanup: remove support for extra actions Aug 28, 2025
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comius !

@rickeylev rickeylev enabled auto-merge August 28, 2025 04:55
@rickeylev rickeylev added this pull request to the merge queue Aug 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2025
@rickeylev rickeylev enabled auto-merge August 28, 2025 05:20
@rickeylev rickeylev added this pull request to the merge queue Aug 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 29, 2025
@rickeylev rickeylev added this pull request to the merge queue Aug 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2025
This removes the support for Bazel "extra actions".

These have been long deprecated and little to no usage. Because of how
long they've
been deprecated, their lack of use, and how long their replacement
(aspects) has
been available, this is not being considered a breaking change.

Fixes bazelbuild/bazel#16455
Fixes #3215

---------

Co-authored-by: Richard Levasseur <[email protected]>
Co-authored-by: Richard Levasseur <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 29, 2025
@rickeylev rickeylev added this pull request to the merge queue Aug 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 29, 2025
@rickeylev rickeylev added this pull request to the merge queue Aug 29, 2025
Merged via the queue into bazel-contrib:main with commit 6046e9e Aug 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove add_py_extra_pseudo_action and are_action_listeners_enabled usages Remove extra action support from Python rules

3 participants