Skip to content

cleanup: remove support for extra actions #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 29, 2025
Merged

cleanup: remove support for extra actions #3210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
056b7dc
cleanup: remove support for extra actions
comius Aug 26, 2025
3fa3d73
Remove unused fields
comius Aug 26, 2025
4611a08
add changelog
rickeylev Aug 28, 2025
d196f1c
lint fixes
rickeylev Aug 28, 2025
cb8184a
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev Aug 28, 2025
7b82c0e
Merge branch 'main' into remove-pseudo-action
rickeylev Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ BEGIN_UNRELEASED_TEMPLATE

[0.0.0]: https://github.com/bazel-contrib/rules_python/releases/tag/0.0.0

{#v0-0-0-removed}
### Removed

* Nothing removed.
{#v0-0-0-changed}
### Changed
* Nothing changed.
Expand All @@ -40,9 +44,6 @@ BEGIN_UNRELEASED_TEMPLATE
### Added
* Nothing added.

{#v0-0-0-removed}
### Removed
* Nothing removed.

END_UNRELEASED_TEMPLATE
-->
Expand All @@ -52,6 +53,12 @@ END_UNRELEASED_TEMPLATE

[0.0.0]: https://github.com/bazel-contrib/rules_python/releases/tag/0.0.0

{#v0-0-0-removed}
### Removed
* (core rules) Support for Bazel's long deprecated "extra actions" has been
removed
([#3215](https://github.com/bazel-contrib/rules_python/issues/3215)).

{#v0-0-0-changed}
### Changed
* Nothing changed.
Expand All @@ -66,9 +73,6 @@ END_UNRELEASED_TEMPLATE
### Added
* Nothing added.

{#v0-0-0-removed}
### Removed
* Nothing removed.

{#v1-6-0}
## [1.6.0] - 2025-08-23
Expand Down
3 changes: 1 addition & 2 deletions python/private/common.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,6 @@ def create_py_info(
if PyInfo in target or (BuiltinPyInfo != None and BuiltinPyInfo in target):
py_info.merge(_get_py_info(target))

deps_transitive_sources = py_info.transitive_sources.build()
py_info.transitive_sources.add(required_py_files)

# We only look at data to calculate uses_shared_libraries, if it's already
Expand All @@ -457,7 +456,7 @@ def create_py_info(
if py_info.get_uses_shared_libraries():
break

return py_info.build(), deps_transitive_sources, py_info.build_builtin_py_info()
return py_info.build(), py_info.build_builtin_py_info()

def _get_py_info(target):
return target[PyInfo] if PyInfo in target or BuiltinPyInfo == None else target[BuiltinPyInfo]
Expand Down
10 changes: 1 addition & 9 deletions python/private/py_executable.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1838,7 +1838,7 @@ def _create_providers(
PyCcLinkParamsInfo(cc_info = cc_info),
)

py_info, deps_transitive_sources, builtin_py_info = create_py_info(
py_info, builtin_py_info = create_py_info(
ctx,
original_sources = original_sources,
required_py_files = required_py_files,
Expand All @@ -1848,14 +1848,6 @@ def _create_providers(
imports = imports,
)

# TODO(b/253059598): Remove support for extra actions; https://github.com/bazelbuild/bazel/issues/16455
listeners_enabled = _py_builtins.are_action_listeners_enabled(ctx)
if listeners_enabled:
_py_builtins.add_py_extra_pseudo_action(
ctx = ctx,
dependency_transitive_python_sources = deps_transitive_sources,
)

providers.append(py_info)
if builtin_py_info:
providers.append(builtin_py_info)
Expand Down
13 changes: 1 addition & 12 deletions python/private/py_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ load(":normalize_name.bzl", "normalize_name")
load(":precompile.bzl", "maybe_precompile")
load(":py_cc_link_params_info.bzl", "PyCcLinkParamsInfo")
load(":py_info.bzl", "PyInfo", "VenvSymlinkEntry", "VenvSymlinkKind")
load(":py_internal.bzl", "py_internal")
load(":reexports.bzl", "BuiltinPyInfo")
load(":rule_builders.bzl", "ruleb")
load(
Expand All @@ -55,8 +54,6 @@ load(
)
load(":version.bzl", "version")

_py_builtins = py_internal

LIBRARY_ATTRS = dicts.add(
COMMON_ATTRS,
PY_SRCS_ATTRS,
Expand Down Expand Up @@ -164,7 +161,7 @@ def py_library_impl(ctx, *, semantics):
imports, venv_symlinks = _get_imports_and_venv_symlinks(ctx, semantics)

cc_info = semantics.get_cc_info_for_library(ctx)
py_info, deps_transitive_sources, builtins_py_info = create_py_info(
py_info, builtins_py_info = create_py_info(
ctx,
original_sources = direct_sources,
required_py_files = required_py_files,
Expand All @@ -175,14 +172,6 @@ def py_library_impl(ctx, *, semantics):
venv_symlinks = venv_symlinks,
)

# TODO(b/253059598): Remove support for extra actions; https://github.com/bazelbuild/bazel/issues/16455
listeners_enabled = _py_builtins.are_action_listeners_enabled(ctx)
if listeners_enabled:
_py_builtins.add_py_extra_pseudo_action(
ctx = ctx,
dependency_transitive_python_sources = deps_transitive_sources,
)

providers = [
DefaultInfo(files = default_outputs, runfiles = runfiles),
py_info,
Expand Down