-
-
Notifications
You must be signed in to change notification settings - Fork 631
feat(pypi): support aarch64 windows on pipstar #3226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(pypi): support aarch64 windows on pipstar #3226
Conversation
82c42d3
to
c4c9668
Compare
We cannot do this because we have tests using the TBH, maybe we should treat this as a bug and fix it. |
Yeah, it's something we should fix. It should be OK for a requirements file to not support the full set of platforms the entire build does. I can see that situation happening in a larger repo. |
Another thought: does this mean if we add a new platform to rules_python's default, downstream user requirements could break? Eek. |
I think the best way would be to hardcode windows to only mean windows intel, then for linux and osx, do similar things. The users should really be specifying things explicitly... Otherwise us adding platforms may break bazel quely. |
Funny enough, but #3307 may fix our CI because |
This adds the necessary bits for Windows ARM64 support when evaluating env markers in requirements files and selecting the right wheels in `experimental_index_url`. Related bazel-contrib#2276
c4c9668
to
2a66ab1
Compare
Just as I had suspected, the new wheels in sphinx deps masked the failure. PTAL, I am wondering if the test changes indicate that we should do something differently - add freethreaded variants to default platforms, or other things. Hence the ask for review. |
This adds the necessary bits for Windows ARM64 support when evaluating
env markers in requirements files and selecting the right wheels in
experimental_index_url
.Related #2276