fix: wrong value of has_py3_only_sources in the PyInfo constructor

[oprypin]

The has_py3_only_sources field was being set to the has_py2_only_sources variable

[gemini-code-assist]

Summary of Changes

Hello @oprypin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the PyInfo constructor that led to incorrect reporting of Python 3-only source files. By fixing a simple variable assignment error, the change ensures that the has_py3_only_sources attribute correctly reflects the presence of Python 3-specific code, thereby improving the reliability of Python build processes and dependency management.

Highlights

• Bug Fix: Corrected an erroneous assignment in the PyInfo constructor where the has_py3_only_sources field was mistakenly assigned the value of has_py2_only_sources.
• Accuracy: Ensured that the PyInfo object accurately reflects whether a module contains Python 3-only source files, which is crucial for correct build logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR correctly fixes a copy-paste error in the _PyInfo_init function, ensuring has_py3_only_sources is assigned the correct value. I've added a comment suggesting to also fix a related bug in the test suite to ensure this change is properly verified.

Additionally, while reviewing _PyInfo_init, I noticed another potential copy-paste error in the argument type checks on lines 136-137 of python/private/py_info.bzl. The checks for transitive_implicit_pyc_files and transitive_implicit_pyc_source_files both incorrectly use transitive_pyc_files as the variable being checked. You may want to address this in a separate change.