Skip to content

fix: wrong value of has_py3_only_sources in the PyInfo constructor #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2025
Merged

fix: wrong value of has_py3_only_sources in the PyInfo constructor #3315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d5e1bb
fix: wrong value of `has_py3_only_sources` in the PyInfo constructor
oprypin Oct 2, 2025
90d7073
Update CHANGELOG.md
oprypin Oct 2, 2025
0a9f453
Update py_info_tests.bzl
oprypin Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ END_UNRELEASED_TEMPLATE

{#v0-0-0-fixed}
### Fixed
* (rules) The `PyInfo` constructor was setting the wrong value for
`has_py3_only_sources` - this is now fixed.
* (bootstrap) The stage1 bootstrap script now correctly handles nested `RUNFILES_DIR`
environments, fixing issues where a `py_binary` calls another `py_binary`
([#3187](https://github.com/bazel-contrib/rules_python/issues/3187)).
Expand Down
2 changes: 1 addition & 1 deletion python/private/py_info.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def _PyInfo_init(
"direct_pyc_files": direct_pyc_files,
"direct_pyi_files": direct_pyi_files,
"has_py2_only_sources": has_py2_only_sources,
"has_py3_only_sources": has_py2_only_sources,
"has_py3_only_sources": has_py3_only_sources,
"imports": imports,
"transitive_implicit_pyc_files": transitive_implicit_pyc_files,
"transitive_implicit_pyc_source_files": transitive_implicit_pyc_source_files,
Expand Down
2 changes: 1 addition & 1 deletion tests/base_rules/py_info/py_info_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def _provide_py_info_impl(ctx):
if ctx.attr.has_py2_only_sources != -1:
kwargs["has_py2_only_sources"] = bool(ctx.attr.has_py2_only_sources)
if ctx.attr.has_py3_only_sources != -1:
kwargs["has_py2_only_sources"] = bool(ctx.attr.has_py2_only_sources)
kwargs["has_py3_only_sources"] = bool(ctx.attr.has_py3_only_sources)

providers = []
providers.append(PyInfo(**kwargs))
Expand Down