-
-
Notifications
You must be signed in to change notification settings - Fork 636
feat(toolchains): Add latest Python versions #3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Ahajha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the available Python toolchain versions by integrating several new patch releases. This update ensures that users have access to the most recent stable and secure Python versions for their development environments, keeping the toolchains up-to-date with the latest official releases. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds definitions for several new Python versions to the toolchain. The changes are straightforward and look good. My review includes a few suggestions to sort the keys in the newly added dictionaries to improve maintainability and consistency with the rest of the file.
"sha256": { | ||
"aarch64-apple-darwin": "29ec457de1b5765eeade189efbe27e2b1f8c7a96e4b79471b7d41a18094b1870", | ||
"aarch64-unknown-linux-gnu": "d46c18f9da8a673cc55de55d8cfb8ed3164849eac50edc222985b60a9eda3be3", | ||
"ppc64le-unknown-linux-gnu": "fd395aa11d82a48bfe3cfdfcd41759ee4b65b3d1de67466329aaef284164650b", | ||
"riscv64-unknown-linux-gnu": "c3b529408c176a222c863c1810ee6a635a7e9deb5f2c73c425181a2383d7da2a", | ||
"s390x-unknown-linux-gnu": "ade377b4668e4a03bd0c2a5316c079b8c0d2d63db7ecd05f24715309c4efb298", | ||
"x86_64-apple-darwin": "ae375cd49fecfc3aecbf942544c34a1c5251f2c2f9b19e0e2b889a9113ccfa62", | ||
"x86_64-pc-windows-msvc": "58a2571b5268fc7891e28cab01f23c3561ef5bc146f1314e32ba32a06754442b", | ||
"aarch64-pc-windows-msvc": "67600a84ba1cf43a826a31c1dbb144b987a6b4627f6e5fb3d34a54511c356187", | ||
"x86_64-unknown-linux-gnu": "848789e630ada4012e64ac744a3f4a8342b975d69f9608c460bdf9f370fa1d30", | ||
"x86_64-unknown-linux-musl": "fed38a53fdff4327295f052a2970692ca194e53444843b5f91bd478c7ffed1ba", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency and maintainability, please sort the keys in this sha256
dictionary alphabetically.
"sha256": { | |
"aarch64-apple-darwin": "29ec457de1b5765eeade189efbe27e2b1f8c7a96e4b79471b7d41a18094b1870", | |
"aarch64-unknown-linux-gnu": "d46c18f9da8a673cc55de55d8cfb8ed3164849eac50edc222985b60a9eda3be3", | |
"ppc64le-unknown-linux-gnu": "fd395aa11d82a48bfe3cfdfcd41759ee4b65b3d1de67466329aaef284164650b", | |
"riscv64-unknown-linux-gnu": "c3b529408c176a222c863c1810ee6a635a7e9deb5f2c73c425181a2383d7da2a", | |
"s390x-unknown-linux-gnu": "ade377b4668e4a03bd0c2a5316c079b8c0d2d63db7ecd05f24715309c4efb298", | |
"x86_64-apple-darwin": "ae375cd49fecfc3aecbf942544c34a1c5251f2c2f9b19e0e2b889a9113ccfa62", | |
"x86_64-pc-windows-msvc": "58a2571b5268fc7891e28cab01f23c3561ef5bc146f1314e32ba32a06754442b", | |
"aarch64-pc-windows-msvc": "67600a84ba1cf43a826a31c1dbb144b987a6b4627f6e5fb3d34a54511c356187", | |
"x86_64-unknown-linux-gnu": "848789e630ada4012e64ac744a3f4a8342b975d69f9608c460bdf9f370fa1d30", | |
"x86_64-unknown-linux-musl": "fed38a53fdff4327295f052a2970692ca194e53444843b5f91bd478c7ffed1ba", | |
}, | |
"sha256": { | |
"aarch64-apple-darwin": "29ec457de1b5765eeade189efbe27e2b1f8c7a96e4b79471b7d41a18094b1870", | |
"aarch64-pc-windows-msvc": "67600a84ba1cf43a826a31c1dbb144b987a6b4627f6e5fb3d34a54511c356187", | |
"aarch64-unknown-linux-gnu": "d46c18f9da8a673cc55de55d8cfb8ed3164849eac50edc222985b60a9eda3be3", | |
"ppc64le-unknown-linux-gnu": "fd395aa11d82a48bfe3cfdfcd41759ee4b65b3d1de67466329aaef284164650b", | |
"riscv64-unknown-linux-gnu": "c3b529408c176a222c863c1810ee6a635a7e9deb5f2c73c425181a2383d7da2a", | |
"s390x-unknown-linux-gnu": "ade377b4668e4a03bd0c2a5316c079b8c0d2d63db7ecd05f24715309c4efb298", | |
"x86_64-apple-darwin": "ae375cd49fecfc3aecbf942544c34a1c5251f2c2f9b19e0e2b889a9113ccfa62", | |
"x86_64-pc-windows-msvc": "58a2571b5268fc7891e28cab01f23c3561ef5bc146f1314e32ba32a06754442b", | |
"x86_64-unknown-linux-gnu": "848789e630ada4012e64ac744a3f4a8342b975d69f9608c460bdf9f370fa1d30", | |
"x86_64-unknown-linux-musl": "fed38a53fdff4327295f052a2970692ca194e53444843b5f91bd478c7ffed1ba", | |
}, |
"sha256": { | ||
"aarch64-apple-darwin": "2577a2629c89b3ff40dc16271cc8826d9ae20217e5a3189bbc7646b496e77687", | ||
"aarch64-unknown-linux-gnu": "21bcf71dccb56ef611f50543b04e63e6585ac063463f2d248cb4ec28118d264d", | ||
"aarch64-pc-windows-msvc": "a36719b442c22488f1ef7caea68943cf0c8dd367330fa5baac3cab4168a8e66a", | ||
"ppc64le-unknown-linux-gnu": "782fbe38b63216cce3fdc4c7a2da86337ccef615fa9384acba7457ef17ad96a2", | ||
"riscv64-unknown-linux-gnu": "c9bbb36a75466386497a38db0f9f707e63aaa8bae38c64d55683242d9b5b56a6", | ||
"s390x-unknown-linux-gnu": "90e3f010692e65425cb503ae789e0ffefb3b5962b83e21d7c642d34cf056d48b", | ||
"x86_64-apple-darwin": "c9fb9ab36c742f14388fd5b6a67cab5e6e1726b52624dafbd37d0176ad1752e1", | ||
"x86_64-pc-windows-msvc": "c110c11de4299b0273caa99a1c7b895427c9441a231b3124bf5228a2e463ef43", | ||
"x86_64-unknown-linux-gnu": "fbf55136d0f955ca2f93aeb7830f993d93acf1b9a729a15c3b6b5220a36bc835", | ||
"x86_64-unknown-linux-musl": "bffd28435d28d55b33e0b90a5521b0220fe38c5ff67b2706cbc9ceb32af0e4a7", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency and maintainability, please sort the keys in this sha256
dictionary alphabetically.
"sha256": { | |
"aarch64-apple-darwin": "2577a2629c89b3ff40dc16271cc8826d9ae20217e5a3189bbc7646b496e77687", | |
"aarch64-unknown-linux-gnu": "21bcf71dccb56ef611f50543b04e63e6585ac063463f2d248cb4ec28118d264d", | |
"aarch64-pc-windows-msvc": "a36719b442c22488f1ef7caea68943cf0c8dd367330fa5baac3cab4168a8e66a", | |
"ppc64le-unknown-linux-gnu": "782fbe38b63216cce3fdc4c7a2da86337ccef615fa9384acba7457ef17ad96a2", | |
"riscv64-unknown-linux-gnu": "c9bbb36a75466386497a38db0f9f707e63aaa8bae38c64d55683242d9b5b56a6", | |
"s390x-unknown-linux-gnu": "90e3f010692e65425cb503ae789e0ffefb3b5962b83e21d7c642d34cf056d48b", | |
"x86_64-apple-darwin": "c9fb9ab36c742f14388fd5b6a67cab5e6e1726b52624dafbd37d0176ad1752e1", | |
"x86_64-pc-windows-msvc": "c110c11de4299b0273caa99a1c7b895427c9441a231b3124bf5228a2e463ef43", | |
"x86_64-unknown-linux-gnu": "fbf55136d0f955ca2f93aeb7830f993d93acf1b9a729a15c3b6b5220a36bc835", | |
"x86_64-unknown-linux-musl": "bffd28435d28d55b33e0b90a5521b0220fe38c5ff67b2706cbc9ceb32af0e4a7", | |
}, | |
"sha256": { | |
"aarch64-apple-darwin": "2577a2629c89b3ff40dc16271cc8826d9ae20217e5a3189bbc7646b496e77687", | |
"aarch64-pc-windows-msvc": "a36719b442c22488f1ef7caea68943cf0c8dd367330fa5baac3cab4168a8e66a", | |
"aarch64-unknown-linux-gnu": "21bcf71dccb56ef611f50543b04e63e6585ac063463f2d248cb4ec28118d264d", | |
"ppc64le-unknown-linux-gnu": "782fbe38b63216cce3fdc4c7a2da86337ccef615fa9384acba7457ef17ad96a2", | |
"riscv64-unknown-linux-gnu": "c9bbb36a75466386497a38db0f9f707e63aaa8bae38c64d55683242d9b5b56a6", | |
"s390x-unknown-linux-gnu": "90e3f010692e65425cb503ae789e0ffefb3b5962b83e21d7c642d34cf056d48b", | |
"x86_64-apple-darwin": "c9fb9ab36c742f14388fd5b6a67cab5e6e1726b52624dafbd37d0176ad1752e1", | |
"x86_64-pc-windows-msvc": "c110c11de4299b0273caa99a1c7b895427c9441a231b3124bf5228a2e463ef43", | |
"x86_64-unknown-linux-gnu": "fbf55136d0f955ca2f93aeb7830f993d93acf1b9a729a15c3b6b5220a36bc835", | |
"x86_64-unknown-linux-musl": "bffd28435d28d55b33e0b90a5521b0220fe38c5ff67b2706cbc9ceb32af0e4a7", | |
}, |
"sha256": { | ||
"aarch64-apple-darwin": "0dc9061b9d8e02a9344aa569eecb795f41f16ac8bb215f973d8db9179700e296", | ||
"aarch64-unknown-linux-gnu": "1b9af3c628cdbef3b9eb4c61df628bbc54f4684ace147f3dc9850c336c44c125", | ||
"ppc64le-unknown-linux-gnu": "c3bae08423519b5224bfc87323b96381bdb9c589fbdc09cd3ce289f6c1ea4ed3", | ||
"riscv64-unknown-linux-gnu": "e8be781bfaf5ad6b83094db96dd60d7dfcd4519f6550740354b4ea57acfbfa21", | ||
"s390x-unknown-linux-gnu": "3c9faf91356d06b4cc993487a71915e7a0585aa592691f6afe8841188e024653", | ||
"x86_64-apple-darwin": "e3b692599bb3c247a2f95c21577f8b85b70924a5f2d672c9e0005608d7b9c907", | ||
"x86_64-pc-windows-msvc": "1dde7aab47a52e81b6bd3f7d1bc5fa2f3c9e428eb5f54f51e8b92ae0a3e2409f", | ||
"aarch64-pc-windows-msvc": "430d9073f22c744d6ea8c224d7b458a6be3620f9bd2389068908c214ea4423f8", | ||
"aarch64-pc-windows-msvc-freethreaded": "187b962d84af18d22f67e069776dff61a223271ae11f44507cfd8693430c03c4", | ||
"x86_64-unknown-linux-gnu": "12dd8995e8ec2df68cd1301b053f415c7884b8aae9d3459a2ac1448f781dbbbc", | ||
"x86_64-unknown-linux-musl": "fbf17b5acd1a33a7a0a6bcabab7065f3adc3de77efbc230555a5019843070b1d", | ||
"aarch64-apple-darwin-freethreaded": "0b7a80716c2557800d8e3133744b9e913476d259cea0160dd8597e58284a5a1c", | ||
"aarch64-unknown-linux-gnu-freethreaded": "5cf655065b59493d39235fec0e30c33a5196bb01cf74cef50907a4f18c8ef02a", | ||
"ppc64le-unknown-linux-gnu-freethreaded": "dbae65b6e747537939c3f2804077bb4e49f528850e68800d54b0e8c4b7768fab", | ||
"riscv64-unknown-linux-gnu-freethreaded": "10390b394f76cb14c808b5c87de37189bc72796e55a55e6e5aca83e4615dd5ca", | ||
"s390x-unknown-linux-gnu-freethreaded": "7e9d32fae045cefe950d8f95ddf1824edc232d1c67b4cdd55ecec5042f05727d", | ||
"x86_64-apple-darwin-freethreaded": "1112caf275e374fbe629c3fde265f1e7675b21553f1607085cedc821d184a4aa", | ||
"x86_64-pc-windows-msvc-freethreaded": "d4b83250fe9fea9563b2fb79111d4af072279b690507ddb14df11f617fd57f7e", | ||
"x86_64-unknown-linux-gnu-freethreaded": "714eec8f42eb023d0c9ed289115d52e96ce73dac7464a5d242b0988eeda90b56", | ||
}, | ||
"strip_prefix": { | ||
"aarch64-apple-darwin": "python", | ||
"aarch64-unknown-linux-gnu": "python", | ||
"ppc64le-unknown-linux-gnu": "python", | ||
"s390x-unknown-linux-gnu": "python", | ||
"riscv64-unknown-linux-gnu": "python", | ||
"x86_64-apple-darwin": "python", | ||
"x86_64-pc-windows-msvc": "python", | ||
"aarch64-pc-windows-msvc": "python", | ||
"x86_64-unknown-linux-gnu": "python", | ||
"x86_64-unknown-linux-musl": "python", | ||
"aarch64-apple-darwin-freethreaded": "python/install", | ||
"aarch64-unknown-linux-gnu-freethreaded": "python/install", | ||
"ppc64le-unknown-linux-gnu-freethreaded": "python/install", | ||
"riscv64-unknown-linux-gnu-freethreaded": "python/install", | ||
"s390x-unknown-linux-gnu-freethreaded": "python/install", | ||
"x86_64-apple-darwin-freethreaded": "python/install", | ||
"x86_64-pc-windows-msvc-freethreaded": "python/install", | ||
"aarch64-pc-windows-msvc-freethreaded": "python/install", | ||
"x86_64-unknown-linux-gnu-freethreaded": "python/install", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency and maintainability, please sort the keys in the sha256
and strip_prefix
dictionaries alphabetically.
"sha256": {
"aarch64-apple-darwin": "0dc9061b9d8e02a9344aa569eecb795f41f16ac8bb215f973d8db9179700e296",
"aarch64-apple-darwin-freethreaded": "0b7a80716c2557800d8e3133744b9e913476d259cea0160dd8597e58284a5a1c",
"aarch64-pc-windows-msvc": "430d9073f22c744d6ea8c224d7b458a6be3620f9bd2389068908c214ea4423f8",
"aarch64-pc-windows-msvc-freethreaded": "187b962d84af18d22f67e069776dff61a223271ae11f44507cfd8693430c03c4",
"aarch64-unknown-linux-gnu": "1b9af3c628cdbef3b9eb4c61df628bbc54f4684ace147f3dc9850c336c44c125",
"aarch64-unknown-linux-gnu-freethreaded": "5cf655065b59493d39235fec0e30c33a5196bb01cf74cef50907a4f18c8ef02a",
"ppc64le-unknown-linux-gnu": "c3bae08423519b5224bfc87323b96381bdb9c589fbdc09cd3ce289f6c1ea4ed3",
"ppc64le-unknown-linux-gnu-freethreaded": "dbae65b6e747537939c3f2804077bb4e49f528850e68800d54b0e8c4b7768fab",
"riscv64-unknown-linux-gnu": "e8be781bfaf5ad6b83094db96dd60d7dfcd4519f6550740354b4ea57acfbfa21",
"riscv64-unknown-linux-gnu-freethreaded": "10390b394f76cb14c808b5c87de37189bc72796e55a55e6e5aca83e4615dd5ca",
"s390x-unknown-linux-gnu": "3c9faf91356d06b4cc993487a71915e7a0585aa592691f6afe8841188e024653",
"s390x-unknown-linux-gnu-freethreaded": "7e9d32fae045cefe950d8f95ddf1824edc232d1c67b4cdd55ecec5042f05727d",
"x86_64-apple-darwin": "e3b692599bb3c247a2f95c21577f8b85b70924a5f2d672c9e0005608d7b9c907",
"x86_64-apple-darwin-freethreaded": "1112caf275e374fbe629c3fde265f1e7675b21553f1607085cedc821d184a4aa",
"x86_64-pc-windows-msvc": "1dde7aab47a52e81b6bd3f7d1bc5fa2f3c9e428eb5f54f51e8b92ae0a3e2409f",
"x86_64-pc-windows-msvc-freethreaded": "d4b83250fe9fea9563b2fb79111d4af072279b690507ddb14df11f617fd57f7e",
"x86_64-unknown-linux-gnu": "12dd8995e8ec2df68cd1301b053f415c7884b8aae9d3459a2ac1448f781dbbbc",
"x86_64-unknown-linux-gnu-freethreaded": "714eec8f42eb023d0c9ed289115d52e96ce73dac7464a5d242b0988eeda90b56",
"x86_64-unknown-linux-musl": "fbf17b5acd1a33a7a0a6bcabab7065f3adc3de77efbc230555a5019843070b1d",
},
"strip_prefix": {
"aarch64-apple-darwin": "python",
"aarch64-apple-darwin-freethreaded": "python/install",
"aarch64-pc-windows-msvc": "python",
"aarch64-pc-windows-msvc-freethreaded": "python/install",
"aarch64-unknown-linux-gnu": "python",
"aarch64-unknown-linux-gnu-freethreaded": "python/install",
"ppc64le-unknown-linux-gnu": "python",
"ppc64le-unknown-linux-gnu-freethreaded": "python/install",
"riscv64-unknown-linux-gnu": "python",
"riscv64-unknown-linux-gnu-freethreaded": "python/install",
"s390x-unknown-linux-gnu": "python",
"s390x-unknown-linux-gnu-freethreaded": "python/install",
"x86_64-apple-darwin": "python",
"x86_64-apple-darwin-freethreaded": "python/install",
"x86_64-pc-windows-msvc": "python",
"x86_64-pc-windows-msvc-freethreaded": "python/install",
"x86_64-unknown-linux-gnu": "python",
"x86_64-unknown-linux-gnu-freethreaded": "python/install",
"x86_64-unknown-linux-musl": "python",
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CI failures require a few modifications in //tests/python/...
Thanks for fixing this up! |
Per request in #3330 (comment)