feat: Add libpython QNX platform support #3372
Conversation
|
@rickeylev / @aignas could you please retrigger CI? It failed due to yesterday's Docker Hub outage |
| "lib/libpython{major}.{minor}.so.1.0".format(**version_dict), | ||
| ], | ||
| "@platforms//os:macos": ["lib/libpython{major}.{minor}.dylib".format(**version_dict)], | ||
| "@platforms//os:qnx": [ |
There was a problem hiding this comment.
Could you please refactor the code so that this is the default? It seems that linux and qnx have the same code here, so in theory we could just default to that. I wonder if that would incidentally also help FreeBSD, which we don't support, but you never know what PR will come in the future.
@rickeylev, what would you think about this?
There was a problem hiding this comment.
done, I think that's a good idea
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
I think this is fine, we can skip the CHANGELOG notes for this because it is not a platform we advertise supporting and there is no CI for this, so this is just a refactor of the select statement.
2 participants
Add libpython QNX platform support.
Note that the qnx py toolchain must come from somewhere else, this doesn't add an interpreter