Add proxy-wasm-cpp-sdk@0.0.0-250925-e5256b0#7228
Add proxy-wasm-cpp-sdk@0.0.0-250925-e5256b0#7228phlax wants to merge 1 commit intobazelbuild:mainfrom
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (proxy-wasm-cpp-sdk) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the new module proxy-wasm-cpp-sdk at version 0.0.0-250925-e5256b0. The overall structure is sound and follows the Bazel Central Registry guidelines. However, I've identified two critical issues that will prevent the presubmit checks from passing. The version specified in MODULE.bazel does not match the directory version, and the repository name used in presubmit.yml is incorrect. Please address these issues.
As per the repository style guide, this PR introduces a new module with new maintainers (leonm1, phlax) and repository (github:envoyproxy/toolshed) in metadata.json, which may require a manual review from @bazelbuild/bcr-maintainers.
phlax
force-pushed
the
proxy-wasm-cpp-sdk
branch
4 times, most recently
from
cab2637 to
4568dd6
Compare
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
phlax
force-pushed
the
proxy-wasm-cpp-sdk
branch
6 times, most recently
from
3838436 to
b568675
Compare
|
cc @leonm1 |
|
this doesnt have the patch that is needed at least by envoy - upstream pr to resolve is here proxy-wasm/proxy-wasm-cpp-sdk#196 |
meteorcloudy
added
the
presubmit-auto-run
phlax
force-pushed
the
proxy-wasm-cpp-sdk
branch
from
b568675 to
6fdc4b8
Compare
bazel-io
dismissed
meteorcloudy’s stale review
Require module maintainers' approval for newly pushed changes.
|
@bazel-io skip_check incompatible_flags |
bazel-io
added
the
skip-incompatible-flags-test
phlax
force-pushed
the
proxy-wasm-cpp-sdk
branch
3 times, most recently
from
89f0bca to
7f8222b
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
proxy-wasm-cpp-sdk
branch
from
7f8222b to
6926af2
Compare
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
|
Close in favor of #7390 |
3 participants
No description provided.