Add proxy-wasm-cpp-sdk@0.0.0-20260123-894dd29#7390
Add proxy-wasm-cpp-sdk@0.0.0-20260123-894dd29#7390meteorcloudy merged 1 commit intobazelbuild:mainfrom
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (proxy-wasm-cpp-sdk) have been updated in this PR. |
There was a problem hiding this comment.
Code Review
This pull request adds the proxy-wasm-cpp-sdk module at version 0.0.0-20260123-894dd29. The submission is well-structured and largely adheres to the Bazel Central Registry guidelines. However, I've identified a critical issue in the presubmit.yml configuration concerning how build targets are referenced. This needs to be corrected to ensure the presubmit checks can pass. Since this is a new module, a review of the metadata.json by @bazelbuild/bcr-maintainers is also advisable as per the contribution guidelines.
|
@bazel-io skip_check unstable_url |
Which modules are you merging? |
|
No modules are merged here, just the list of maintainers between this pr and the one from #7228 |
6efad03 to
c3c12da
Compare
|
@bazel-io skip_check incompatible_flags |
bfa9f0e to
1636a21
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1636a21 to
5b7d55f
Compare
|
This needs a patch of emsdk to be bazel 9 compatible |
Adds proxy-wasm-cpp-sdk module based on commit
894dd29(2026-01-23), newer than existing PR'se5256b0(2025-09-25).Module Configuration
0.0.0-20260123-894dd29(8-digit date format)Patches
proxy-wasm-cpp-sdk.patch- Comments out emscriptenALLOW_MEMORY_GROWTHandINITIAL_HEAPflags (from envoyproxy/toolshed)module_version.patch- Updates MODULE.bazel version string from0.0.0to0.0.0-20260123-894dd29Notes
Upstream removed
rules_protodependency between commits e5256b0 and 894dd29.@bazel-io skip_check unstable_url