Skip to content

Add proxy-wasm-cpp-sdk@0.0.0-20260123-894dd29#7390

Merged
meteorcloudy merged 1 commit intobazelbuild:mainfrom
mmorel-35:proxy-wasm-cpp-sdk
Feb 4, 2026
Merged

Add proxy-wasm-cpp-sdk@0.0.0-20260123-894dd29#7390
meteorcloudy merged 1 commit intobazelbuild:mainfrom
mmorel-35:proxy-wasm-cpp-sdk

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Feb 2, 2026

Adds proxy-wasm-cpp-sdk module based on commit 894dd29 (2026-01-23), newer than existing PR's e5256b0 (2025-09-25).

Module Configuration

Patches

  1. proxy-wasm-cpp-sdk.patch - Comments out emscripten ALLOW_MEMORY_GROWTH and INITIAL_HEAP flags (from envoyproxy/toolshed)
  2. module_version.patch - Updates MODULE.bazel version string from 0.0.0 to 0.0.0-20260123-894dd29

Notes

Upstream removed rules_proto dependency between commits e5256b0 and 894dd29.

@bazel-io skip_check unstable_url

@bazel-io
Copy link
Member

bazel-io commented Feb 2, 2026

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (proxy-wasm-cpp-sdk) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the proxy-wasm-cpp-sdk module at version 0.0.0-20260123-894dd29. The submission is well-structured and largely adheres to the Bazel Central Registry guidelines. However, I've identified a critical issue in the presubmit.yml configuration concerning how build targets are referenced. This needs to be corrected to ensure the presubmit checks can pass. Since this is a new module, a review of the metadata.json by @bazelbuild/bcr-maintainers is also advisable as per the contribution guidelines.

@mmorel-35
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Feb 2, 2026
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Feb 3, 2026
@meteorcloudy
Copy link
Member

Adds proxy-wasm-cpp-sdk module based on commit 894dd29 (2026-01-23), newer than existing PR's e5256b0 (2025-09-25). Merges maintainer lists from both efforts.

Which modules are you merging?

@mmorel-35
Copy link
Contributor Author

No modules are merged here, just the list of maintainers between this pr and the one from #7228

@mmorel-35
Copy link
Contributor Author

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Feb 3, 2026
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

@meteorcloudy ,

This needs a patch of emsdk to be bazel 9 compatible

@meteorcloudy meteorcloudy merged commit 995e8f3 into bazelbuild:main Feb 4, 2026
13 checks passed
@mmorel-35 mmorel-35 deleted the proxy-wasm-cpp-sdk branch February 4, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants