Add new bazel_first_party and bazel_third_party features#28975
Open
keith wants to merge 1 commit intobazelbuild:masterfrom
Open
Add new bazel_first_party and bazel_third_party features#28975keith wants to merge 1 commit intobazelbuild:masterfrom
keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
bot
added
the
awaiting-review
|
@keith Could you please take a look at the failing checks? |
fmeum
reviewed
Mar 13, 2026
src/main/java/com/google/devtools/build/lib/skyframe/RepoPackageArgsFunction.java
Outdated
Show resolved
Hide resolved
keith
force-pushed
the
ks/add-new-bazel_first_party-and-bazel_third_party-features
branch
3 times, most recently
from
48c1061 to
e56887a
Compare
This adds 2 new features based on if the code is being compiled as part of the main repo, or as part of a third party dependency. This allows users to customize C++ toolchains (or other rules) based on these features. This can replace some uses of `--per_file_copt=external/.*@SOMETHING`. This also allows us to combine features in a way that default toolchain features can be disabled for third party code. For example you can disable layering_check for third party code, since you likely don't care if they correctly define their deps once you're pulling them in.
keith
force-pushed
the
ks/add-new-bazel_first_party-and-bazel_third_party-features
branch
from
e56887a to
6e863a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 2 new features based on if the code is being compiled as part
of the main repo, or as part of a third party dependency. This allows
users to customize C++ toolchains (or other rules) based on these
features. This can replace some uses of
--per_file_copt=external/.*@SOMETHING.This also allows us to combine features in a way that default toolchain
features can be disabled for third party code. For example you can
disable layering_check for third party code, since you likely don't care
if they correctly define their deps once you're pulling them in.