Skip to content

SIMSBIOHUB-869: Improve UX for Team–Policy Assignments#334

Merged
mauberti-bc merged 13 commits intodevfrom
SIMSBIOHUB-869
Mar 3, 2026
Merged

SIMSBIOHUB-869: Improve UX for Team–Policy Assignments#334
mauberti-bc merged 13 commits intodevfrom
SIMSBIOHUB-869

Conversation

@mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Feb 13, 2026

Links to Jira Tickets

Description of Changes

  • Added reusable ServerPaginatedDataGrid for server-side pagination
  • Adopted shared grid across:
    • Policies
    • Teams
    • Team-Policy assignments
  • Added create/edit dialogs and shared form for team-policy assignments
  • Implemented add/edit/remove flows for team-policy assignments (edit handled as create new + delete old per current API contract)

Testing Notes

  • Should be able to add/edit/delete:
    • Teams
    • Policies
    • Assignments

@mauberti-bc mauberti-bc added the Not Ready For Review Addressing feedback and/or refactoring label Feb 13, 2026
@mauberti-bc mauberti-bc added the Do Not Merge PR should not be merged label Feb 25, 2026
@mauberti-bc mauberti-bc changed the title SIMSBIOHUB-869: Policy Page Styling Update SIMSBIOHUB-869: UX for Team–Policy Assignments Feb 28, 2026
@mauberti-bc mauberti-bc changed the title SIMSBIOHUB-869: UX for Team–Policy Assignments SIMSBIOHUB-869: Improve UX for Team–Policy Assignments Feb 28, 2026
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Do Not Merge PR should not be merged Not Ready For Review Addressing feedback and/or refactoring labels Feb 28, 2026
Copy link
Collaborator

@dwhogan dwhogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great extractions into PageSection, ServerPaginatedDataGrid and showApiErrorDialog.
Better use of API createTeamPolicy.

UX improved to make flow explicit.

@mauberti-bc mauberti-bc marked this pull request as ready for review March 3, 2026 22:11
Copy link
Collaborator

@dwhogan dwhogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add of the searches in the assignment dialog

NIT(edge case, if the operator clicks in the team field after selecting a team, search does not work as expected, easier to use the "clear button")

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

@mauberti-bc
Copy link
Collaborator Author

Nice add of the searches in the assignment dialog

NIT(edge case, if the operator clicks in the team field after selecting a team, search does not work as expected, easier to use the "clear button")

This was actually intentional, but you pointed out that it creates a similar problem in a different direction. We can address in a separate PR because I think the problem is specific to the CustomAutocomplete

@mauberti-bc mauberti-bc merged commit d8a8219 into dev Mar 3, 2026
18 checks passed
@mauberti-bc mauberti-bc deleted the SIMSBIOHUB-869 branch March 3, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For Review PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants