Conversation
Invalid S3 credentials are better described as "forbidden" (HTTP 403). Likewise, a mismatch of S3 credentials between what's supplied in the client request and what COMS has in its database is better described as a "conflict" (HTTP 409). Supporting multiple sets of valid credentials on a bucket at any time is non-trivial (credentials may have varying levels of access), so for now, only allow one set of them at any time.
Coverage Report
|
TimCsaky
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, when creating or updating a bucket:
This PR:
These changes better align with the associated HTTP response reason phrase; invalid credentials are better classified as forbidden (403), and mismatching S3 credentials as a conflict (409) with the COMS database.
SHOWCASE-3941
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
bcgov/bcbox#235 exposes the actual COMS API error message to the user (this wasn't the case previously). Updating the error message inside COMS allows a more descriptive error to be shown to the user.
Supporting multiple sets of valid credentials on a bucket at any time will be non-trivial (i.e. credentials may have varying levels of access), so for now, only allow one set of them at any time.