Skip to content

Restrict some features for non-IDIR users#307

Merged
norrisng-bc merged 3 commits intomasterfrom
idp
Jul 3, 2025
Merged

Restrict some features for non-IDIR users#307
norrisng-bc merged 3 commits intomasterfrom
idp

Conversation

@TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented May 28, 2025

Description

  • user search requires full email address when authenticating with a non-idir token
  • endpoint for making file public not available for non-idir users
  • non-idir user cannot use create bucket (PUT /bucket)
  • non-idir user CAN create sub-folder (PUT /bucket/:bucketId/child) (create sub-folder requires CREATE perm on parent)

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3980

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@TimCsaky TimCsaky marked this pull request as draft May 28, 2025 00:10
@TimCsaky TimCsaky force-pushed the idp branch 2 times, most recently from c8f44f8 to 7e09e9e Compare May 28, 2025 19:24
@github-actions
Copy link

github-actions bot commented May 28, 2025

Coverage Report

Totals Coverage
Statements: 55.61% ( 3057 / 5497 )
Methods: 45.79% ( 332 / 725 )
Lines: 62.24% ( 1833 / 2945 )
Branches: 48.82% ( 892 / 1827 )

@TimCsaky TimCsaky changed the title Restrict non-idir user search Restrict non-idir user features Jun 2, 2025
@norrisng-bc norrisng-bc force-pushed the idp branch 4 times, most recently from 56c5446 to 5fedb8a Compare July 3, 2025 22:40
@norrisng-bc norrisng-bc changed the title Restrict non-idir user features Restrict some features for non-IDIR users Jul 3, 2025
@norrisng-bc norrisng-bc marked this pull request as ready for review July 3, 2025 22:52
@norrisng-bc norrisng-bc merged commit e182aa0 into master Jul 3, 2025
13 checks passed
@norrisng-bc norrisng-bc deleted the idp branch July 23, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants