Conversation
kyle1morel
force-pushed
the
feature/eslint
branch
from
bd7e9ea to
cb3fc14
Compare
Coverage Report (Application)
|
Coverage Report (Frontend)
|
kyle1morel
force-pushed
the
feature/eslint
branch
from
f3daa2b to
f3910be
Compare
qhanson55
approved these changes
Jan 14, 2026
Fix remainder of issues
kyle1morel
force-pushed
the
feature/eslint
branch
from
8dca8ca to
149d470
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backend changes
Update tsconfig to correctly extend from
@tsconfig/node24/tsconfig.jsonUpdate eslint to v9.x
Currently using
tseslint.configs.recommended&tseslint.configs.stylisticinstead of theTypeCheckedvariants. Recommend moving to those soon, but additional (difficult) changes will be required.Thousands of lint changes to comply with new eslint v9.x settings.
Frontend changes
Array->[]syntax. This slipped in during a replace all. Will be required anyways once the frontend eslint is updated as well.https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-316
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
Further comments