chore: potential fix for code scanning alert no. 34: Server-side request forgery #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est forgery Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Addresses CodeQL java/polynomial-redos alert by replacing regex-based trailing dot removal with manual string operations. - Remove trailing dots using index-based approach (O(n)) - Avoids polynomial time complexity from regex on uncontrolled input - Maintains same functionality: removes trailing dots and lowercases - Prevents ReDoS (Regular Expression Denial of Service) attacks
DerekRoberts
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Server-Side Request Forgery (SSRF) vulnerability (code scanning alert #34) in the Maven Wrapper downloader by implementing stricter hostname validation with canonicalization.
Key changes:
- Adds a
canonicalizeHost()helper method to normalize hostnames by removing trailing dots and converting to lowercase - Refactors
isAllowedUrl()to use exact hostname matching after canonicalization, preventing bypass attempts using case variations, trailing dots, or subdomain manipulation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Implements all Copilot AI suggestions for improved security and performance: 1. Performance: Pre-compute canonicalized allowed hosts in static field - Avoids recalculating on every URL validation - Uses CANONICALIZED_ALLOWED_HOSTS.contains() for O(1) lookup 2. Security: Return null for invalid hostnames instead of empty string - Prevents potential security bypass with malformed URLs - Adds explicit null check in isAllowedUrl() 3. Edge case: Handle hostnames that are all dots - Returns null when hostname consists entirely of dots - Prevents empty string from matching 4. Locale safety: Use toLowerCase(Locale.ROOT) - Ensures consistent behavior across all locales - Prevents locale-specific case conversion issues (e.g., Turkish locale)
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/bcgov/quickstart-openshift-backends/security/code-scanning/34
The best way to fix the SSRF risk is to make the URL validation more robust and ensure that even tricky edge cases (e.g., subdomains, mixed case, trailing dots, etc.) are handled. Specifically:
isAllowedUrlmethod in.mvn/wrapper/MavenWrapperDownloader.javato:All code edits are restricted to the shown
.mvn/wrapper/MavenWrapperDownloader.javacode.Suggested fixes powered by Copilot Autofix. Review carefully before merging.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: