Skip to content

chore: potential fix for code scanning alert no. 34: Server-side request forgery #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DerekRoberts merged 3 commits into from
Dec 8, 2025
Merged

chore: potential fix for code scanning alert no. 34: Server-side request forgery #398

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c86ab26
chore: Potential fix for code scanning alert no. 34: Server-side requ…
DerekRoberts Dec 8, 2025
93be372
fix: replace regex with manual string ops to prevent ReDoS
DerekRoberts Dec 8, 2025
f5c6ecb
refactor: address Copilot feedback for SSRF protection
DerekRoberts Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions backend-java/.mvn/wrapper/MavenWrapperDownloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,17 @@
"repo1.maven.org"
);

/**
* Canonicalizes the hostname by removing any trailing dots and converting to lowercase.
*/
private static String canonicalizeHost(String host) {
if (host == null) {
return "";
}
// Remove trailing dots and make lowercase
return host.replaceAll("\\.+$", "").toLowerCase();
}

public static void main( String[] args )
{
log( "Apache Maven Wrapper Downloader " + WRAPPER_VERSION );
Expand Down Expand Up @@ -99,8 +110,15 @@
*/
private static boolean isAllowedUrl( URL url )
{
return "https".equalsIgnoreCase(url.getProtocol()) &&
ALLOWED_MAVEN_REPO_HOSTS.stream().anyMatch(h -> h.equalsIgnoreCase(url.getHost()));
// Only allow HTTPS, and an EXACT host match after canonicalization.
if (!"https".equalsIgnoreCase(url.getProtocol())) {
return false;
}
String actualHost = canonicalizeHost(url.getHost());
// No subdomain allowed, just exact host match.
return ALLOWED_MAVEN_REPO_HOSTS.stream()
.map(MavenWrapperDownloader::canonicalizeHost)
.anyMatch(h -> h.equals(actualHost));
}

private static void downloadFileFromURL( URL wrapperUrl, Path wrapperJarPath )
Expand Down
Loading