32485 - Email notification for new accounts#3642
Conversation
|
bcgov/sbc-common-components#395 merge first |
queue_services/account-mailer/src/account_mailer/resources/worker.py
Outdated
Show resolved
Hide resolved
...count-mailer/src/account_mailer/email_templates/nonbcsc_org_approved_notification_email.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
How would we know which user created an org then? If the user could be None?
I don't think you want people without a user row creating an org, plus it's needed for membership (relationship between user_id and org_id)
Also you don't typically change your production code just so the unit tests pass, it's usually the other way around - if the unit tests aren't creating a proper user row from the start then you're taking a flow that typically isn't ran in production?
I don't see any rows in prod with an empty created_by_id
seeker25
left a comment
seeker25
left a comment
There was a problem hiding this comment.
LGTM, just small tweak please
|
2 participants
Issue #:
bcgov/entity#32485
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).