install renamed scripts as symlinks if --symlink-install flag is set#673
Open
heuristicus wants to merge 3 commits intobdaiinstitute:mainfrom
Open
install renamed scripts as symlinks if --symlink-install flag is set#673heuristicus wants to merge 3 commits intobdaiinstitute:mainfrom
heuristicus wants to merge 3 commits intobdaiinstitute:mainfrom
Conversation
heuristicus
requested review from
METEORITENMAX,
khughes-bdai,
mhidalgo-rai and
tcappellari-bdai
as code owners
Contributor
Author
|
Seems that just changing to symlink may not be sufficient as launch complains about not being able to find an executable |
Signed-off-by: Michal Staniaszek <m.staniaszek@gmail.com>
mhidalgo-rai
reviewed
Jun 2, 2025
Collaborator
mhidalgo-rai
left a comment
mhidalgo-rai
left a comment
There was a problem hiding this comment.
@heuristicus would it be simpler to just rename the scripts? Executable permissions and a shebang line should do.
Contributor
Author
|
That might be simpler but I'm not sure how it would affect module discoverability and other things if the |
tcappellari-bdai
approved these changes
Jul 29, 2025
Collaborator
tcappellari-bdai
left a comment
tcappellari-bdai
left a comment
There was a problem hiding this comment.
im ok with this change. Please rebase and I'll get it merged in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Overview
Fixes #672, which could be confusing if users build
spot_driverwith the--symlink-installflag ofcolcon build.Testing Done
Run
colcon build --symlink-install --packages-select spot_driverand verify thatspot_rosandspot_alertsare now symlinks. Behaviour without symlink flag should be the same.