Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Overview
The goal of this PR is to get rid of the steps that push the docker image built in CI to a RAI specific registry, as this causes permissions errors when trying to run CI for external users. Instead, the docker image is built from scratch and used within the same job. This is modeled after the synchros2 CI job which does not have issues running for external users.
We have also not been using any of the information provided by coveralls or the docs, so I removed those steps from the CI workflow to simplify this further. I am open to moving these changes back in if anyone feels strongly about it.
Testing Done
CI is running successfully on this PR