fix: MenuFlyout sub-item tree direction and icon in RTL mode#1313
Draft
fix: MenuFlyout sub-item tree direction and icon in RTL mode#1313
Conversation
Co-authored-by: bdlukaa <45696119+bdlukaa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MenuFlyout incorrect path for right-to-left directionality
fix: MenuFlyout sub-item tree direction and icon in RTL mode
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MenuFlyoutSubItemalways opened its sub-menu to the right and showed achevron_righticon regardless of text directionality, producing broken UX in RTL layouts.Changes
Direction-aware trailing icon — Replaced the static
WindowsIcon(WindowsIcons.chevron_right)default trailing with a new private_MenuFlyoutSubItemChevronwidget that readsDirectionalityat build time and renderschevron_leftin RTL /chevron_rightin LTR.RTL-aware sub-menu positioning — Added
textDirectionfield to_SubItemPositionDelegate. In RTL mode the sub-menu opens to the left of the parent item by default, falling back to the right only if it would overflow the left edge. LTR behavior is unchanged.Directionalitypassed at show time —_MenuFlyoutSubItemState.show()now passesDirectionality.of(context)to_SubItemPositionDelegate.Tests
chevron_righticon present,chevron_leftabsentchevron_lefticon present,chevron_rightabsentleftedge is to the left of the parent item'sleftedgeOriginal prompt
MenuFlyouttree chooses the wrong path when right-to-left is enabled #1290📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.