allow both individual ports and ranges of ports to be passed as opt #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail5555
force-pushed
the
combine-ports-and-range-input
branch
from
3478a6f to
aa113a3
Compare
mikhail5555
force-pushed
the
combine-ports-and-range-input
branch
from
dafd48e to
b5d8818
Compare
mikhail5555
force-pushed
the
combine-ports-and-range-input
branch
from
0ef3902 to
20cb239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added also the alias
rangetoportsso it is still backwards compatiable.closes #780
Edit i just saw this was already attempted to be implemented in #761 (comment), so i guess i will close this pr again since this is an unwanted feature (Or has the opinion on this changed since then?)
(My usecase: the top 10_000 ports is often too big of an argument to provide in one go to the tool, because it exceeds the linux argument length, so being able to combine individual ports & ranges is kinda a must for this use-case to stay under the max argument size)