Skip to content

allow both individual ports and ranges of ports to be passed as opt #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikhail5555 wants to merge 6 commits into from
Closed

allow both individual ports and ranges of ports to be passed as opt #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35a5023
allow both individual ports and ranges of ports to be passed as opt
mikhail5555 Jun 20, 2025
aa113a3
fix broken tests
mikhail5555 Jun 20, 2025
9cb29b5
fix lazy runtime error
mikhail5555 Jun 20, 2025
b5d8818
remove lazy
mikhail5555 Jun 20, 2025
bf158aa
use custom type to make value_parser work
mikhail5555 Jun 20, 2025
20cb239
remove unnecessary into
mikhail5555 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions benches/benchmark_portscan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use async_std::task::block_on;
use criterion::{criterion_group, criterion_main, Criterion};
use rustscan::input::{Opts, PortRange, ScanOrder};
use rustscan::input::{Opts, ScanOrder};
use rustscan::port_strategy::PortStrategy;
use rustscan::scanner::Scanner;
use std::hint::black_box;
Expand All @@ -20,11 +20,8 @@ fn bench_address() {
}

fn bench_port_strategy() {
let range = PortRange {
start: 1,
end: 1_000,
};
let _strategy = PortStrategy::pick(&Some(range.clone()), None, ScanOrder::Serial);
let range = (1..=1000).collect::<Vec<u16>>();
let _strategy = PortStrategy::pick(Some(range), ScanOrder::Serial);
}

fn bench_address_parsing() {
Expand All @@ -47,12 +44,9 @@ fn bench_address_parsing() {

fn criterion_benchmark(c: &mut Criterion) {
let addrs = vec!["127.0.0.1".parse::<IpAddr>().unwrap()];
let range = PortRange {
start: 1,
end: 1_000,
};
let strategy_tcp = PortStrategy::pick(&Some(range.clone()), None, ScanOrder::Serial);
let strategy_udp = PortStrategy::pick(&Some(range.clone()), None, ScanOrder::Serial);
let range = (1..=1000).collect::<Vec<u16>>();
let strategy_tcp = PortStrategy::pick(Some(range.clone()), ScanOrder::Serial);
let strategy_udp = PortStrategy::pick(Some(range.clone()), ScanOrder::Serial);

let scanner_tcp = Scanner::new(
&addrs,
Expand Down
Loading
Loading