Fix #6176: Clear error message when EDITOR not set#6311
Merged
snejus merged 5 commits intobeetbox:masterfrom Mar 3, 2026
Merged
Fix #6176: Clear error message when EDITOR not set#6311snejus merged 5 commits intobeetbox:masterfrom
snejus merged 5 commits intobeetbox:masterfrom
Conversation
Contributor
Author
|
All testing was done on docker image without vi or any other text editor, please let me know if more test is required. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6311 +/- ##
==========================================
- Coverage 69.33% 69.33% -0.01%
==========================================
Files 141 141
Lines 18793 18794 +1
Branches 3061 3061
==========================================
Hits 13031 13031
- Misses 5117 5118 +1
Partials 645 645
🚀 New features to boost your workflow:
|
|
Nice! just installed today and ran into this confusing error. |
snejus
requested changes
Jan 27, 2026
Member
|
Merged master into this and moved the changelog note under the Unreleased section. Thanks! Edit: also fixed the line too long lint issue. |
snejus
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6176.
(...)
To Do
Documentation.(If you've added a new command-line flag, for example, find the appropriate page underdocs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)Tests.(Very much encouraged but not strictly required.)Changed one line to ensure expected behavior as mentioned in the issue, now
beet config -ewill have info message when no text editor is available.