Skip to content

Fix #6176: Clear error message when EDITOR not set #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snejus merged 5 commits into from
Mar 3, 2026
Merged

Fix #6176: Clear error message when EDITOR not set #6311

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8940e77
Fixed error with Errno2 corresponding to set editor in enviroment var…
MatMacinf Jan 22, 2026
5741be9
Fixed error with Errno2 corresponding to set editor in enviroment var…
MatMacinf Jan 22, 2026
2365377
Added handling FileNotFoundError specifically, changed chanelog
MatMacinf Feb 3, 2026
503d5c7
Merge branch 'master' into bugfix_editor
snejus Mar 3, 2026
65d04f4
Fix lint
snejus Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions beets/ui/commands/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,19 @@
"""
path = cli_options.config or config.user_config_path()
editor = editor_command()

if not editor:
raise ui.UserError(
"Please set the VISUAL or EDITOR environment variable to edit configuration."

Check failure on line 56 in beets/ui/commands/config.py

View workflow job for this annotation

GitHub Actions / Check linting

Ruff (E501) 

beets/ui/commands/config.py:56:89: E501 Line too long (89 > 88)
)
try:
if not os.path.isfile(path):
open(path, "w+").close()
interactive_open([path], editor)
except FileNotFoundError:
raise ui.UserError(f"Editor {editor!r} not found.")
except OSError as exc:
message = f"Could not edit configuration: {exc}"
if not editor:
message += (
". Please set the VISUAL (or EDITOR) environment variable"
)
raise ui.UserError(message)
raise ui.UserError(f"Could not edit configuration: {exc}")


config_cmd = ui.Subcommand("config", help="show or edit the user configuration")
Expand Down
2 changes: 2 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ Bug fixes
backends, such as ``mp3gain``. :bug:`2946`
- :doc:`plugins/mbpseudo`: Fix crash due to missing ``artist_credit`` field in
the MusicBrainz API response. :bug:`6339`
- :ref:`config-cmd`: Improved error message when user-configured editor does not
exist. :bug:`6176`

..
For plugin developers
Expand Down
Loading