Skip to content

Conversation

@johnzhou721
Copy link
Contributor

I've seen that some of the tests I'm hereby marking with @pytest.mark.flaky(retries=5, delay=1) has failed on the main branch. Given that CI's machine is very slow, I've bumped some timeouts and added a flaky mark as a defensive measure (to reduce intermittnet failures.)

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

I've seen that some of the tests I'm hereby marking with ``@pytest.mark.flaky(retries=5, delay=1)`` has failed on the main branch.  Given that CI's machine is very slow, I've bumped some timeouts and added a flaky mark as a defensive measure (to reduce intermittnet failures.)
@johnzhou721
Copy link
Contributor Author

I was specifically talking about the failures in this run.

Also -- I am aware that core team mebers are on leave and may not respond for up to 8 days.

Copy link
Member

@HalfWhitt HalfWhitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not at all familiar with what #3973's doing, but this seems reasonable to me, and hey, it's passing! 😃

@HalfWhitt HalfWhitt merged commit 7f8c01f into beeware:main Dec 31, 2025
57 checks passed
@freakboy3742
Copy link
Member

This is a good immediate workaround; however probe.redraw(... delay=5) has a longer term problem - it means the test actually takes 5 seconds to run. This change has increased the runtime for the test suite by at least 18 seconds. What we need here is a timeout, not a hard delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants