Skip to content

Bump timeouts for new WebView tests #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HalfWhitt merged 3 commits into from
Dec 31, 2025
Merged

Bump timeouts for new WebView tests #4033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8a7004
Bump timeouts for new WebView tests
johnzhou721 Dec 29, 2025
52183df
add change
johnzhou721 Dec 29, 2025
9e9b47f
[Still Ready For Review] Bump timeouts; another excuse for this is to…
johnzhou721 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/4033.misc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Some WebView intermittent failures in testbed from the WebView navigation handler PR has been fixed.
15 changes: 9 additions & 6 deletions testbed/tests/widgets/test_webview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,18 +389,20 @@ async def test_retrieve_cookies(widget, probe, on_load):
assert cookie.expires is None


@pytest.mark.flaky(retries=5, delay=1)
async def test_on_navigation_starting_sync_no_handler(widget, probe, on_load):
# This test is required for full coverage because on android, setting
# the URL does not trigger shouldOverrideUrlLoading()
await widget.evaluate_javascript('window.location.assign("https://beeware.org/")')
await asyncio.sleep(2)
await asyncio.sleep(5)
await widget.evaluate_javascript(
'window.location.assign("https://beeware.org/docs/")'
)
await asyncio.sleep(2)
await asyncio.sleep(5)
assert widget.url == "https://beeware.org/docs/"


@pytest.mark.flaky(retries=5, delay=1)
async def test_on_navigation_starting_sync(widget, probe, on_load):
if not getattr(widget._impl, "SUPPORTS_ON_NAVIGATION_STARTING", True):
pytest.skip("Platform doesn't support on_navigation_starting")
Expand Down Expand Up @@ -441,17 +443,18 @@ def handler(widget, url, **kwargs):
await widget.evaluate_javascript(
'window.location.assign("https://github.com/beeware/toga/")'
)
await probe.redraw("Attempt to navigate to forbidden URL", delay=1)
await probe.redraw("Attempt to navigate to forbidden URL", delay=5)

assert widget.url == "https://github.com/beeware/"
# simulate browser navigation to allowed url
await widget.evaluate_javascript(
'window.location.assign("https://beeware.org/docs/")'
)
await probe.redraw("Attempt to navigate to allowed URL", delay=1)
await probe.redraw("Attempt to navigate to allowed URL", delay=5)
assert widget.url == "https://beeware.org/docs/"


@pytest.mark.flaky(retries=5, delay=1)
async def test_on_navigation_starting_async(widget, probe, on_load):
if not getattr(widget._impl, "SUPPORTS_ON_NAVIGATION_STARTING", True):
pytest.skip("Platform doesn't support on_navigation_starting")
Expand Down Expand Up @@ -492,12 +495,12 @@ async def handler(widget, url, **kwargs):
await widget.evaluate_javascript(
'window.location.assign("https://github.com/beeware/toga/")'
)
await probe.redraw("Attempt to navigate to denied URL", delay=1)
await probe.redraw("Attempt to navigate to denied URL", delay=5)
assert widget.url == "https://github.com/beeware/"

# simulate browser navigation to allowed url
await widget.evaluate_javascript(
'window.location.assign("https://beeware.org/docs/")'
)
await probe.redraw("Attempt to navigate to allowed URL", delay=1)
await probe.redraw("Attempt to navigate to allowed URL", delay=5)
assert widget.url == "https://beeware.org/docs/"