Updated Actual default values #2502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
haslinghuis
approved these changes
Jun 6, 2021
McGiverGim
reviewed
Jun 7, 2021
Comment on lines
+2700
to
+2703
| } else if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) { | ||
| rcRateDefault = (70).toFixed(0); | ||
| rateDefault = (670).toFixed(0); | ||
| expoDefault = (0).toFixed(2); |
Member
There was a problem hiding this comment.
We have default values in this file? I didn't notice it before. I thought all the defaults were at fc.js.
Member
Author
There was a problem hiding this comment.
yes it is designed like that in the @fgiudice98 original code for Rate types.
Member
Author
There was a problem hiding this comment.
Thougth that we never had Rate defaults in fc.js
Member
There was a problem hiding this comment.
I don't like the way it is, but changing it now is outside of the scope of this PR, so to me is ok.
Member
Author
There was a problem hiding this comment.
Maybe we can made this change for next PR's yes, i think it make sense.
McGiverGim
approved these changes
Jun 8, 2021
mikeller
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates new Actual default values to go with betaflight/betaflight#10724