Skip to content

Updated Actual default values #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Updated Actual default values #2502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/js/tabs/pid_tuning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2697,6 +2697,10 @@ TABS.pid_tuning.changeRatesSystem = function(sameType) {
rc_rate_pitch_e.val((FC.RC_TUNING.rcPitchRate * 1000).toFixed(0));
rc_rate_e.val((FC.RC_TUNING.RC_RATE * 1000).toFixed(0));
rc_rate_yaw_e.val((FC.RC_TUNING.rcYawRate * 1000).toFixed(0));
} else if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) {
rcRateDefault = (70).toFixed(0);
rateDefault = (670).toFixed(0);
expoDefault = (0).toFixed(2);
Comment on lines +2700 to +2703
Copy link
Member

@McGiverGim McGiverGim Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have default values in this file? I didn't notice it before. I thought all the defaults were at fc.js.

Copy link
Member Author

@asizon asizon Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is designed like that in the @fgiudice98 original code for Rate types.

Copy link
Member Author

@asizon asizon Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thougth that we never had Rate defaults in fc.js

Copy link
Member

@McGiverGim McGiverGim Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the way it is, but changing it now is outside of the scope of this PR, so to me is ok.

Copy link
Member Author

@asizon asizon Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can made this change for next PR's yes, i think it make sense.

} else {
rcRateDefault = (200).toFixed(0);
rateDefault = (670).toFixed(0);
Expand Down