Fix backup and restore in presets by moving expert mode check #2879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
force-pushed
the
fix_expert_mode
branch
2 times, most recently
from
f07abb6 to
7a17d20
Compare
This comment has been minimized.
This comment has been minimized.
haslinghuis
force-pushed
the
fix_expert_mode
branch
from
7a17d20 to
2fb9308
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
Do you want to test this code? Here you have an automated build: |
|
made a couple of different tests and compares. Backup as well as loading works as designed. Did this tests on Mac 10.15.7 (Catalina) |
limonspb
approved these changes
Apr 2, 2022
Member
|
AUTOMERGE: (FAIL)
|
blckmn
approved these changes
Apr 3, 2022
Member
|
just tested. Works as expected. Lets merge |
chmelevskij
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #2866 the backup and restore buttons did not work.
Moving the check from closing the connection to opening a new connection should solve it.