Skip to content

Conversation

@YarosMallorca
Copy link
Contributor

As suggested by Joshua Bardwell here it is not good that the UI is very confusing in the Filter tab.
Here's how the UI looks after these changes:

image

It makes it a bit clearer that the ON/OFF dropdowns don't affect the "Profile Independent" and "Profile Dependent" Filter settings, instead they affect the sliders.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis
Copy link
Member

image

@haslinghuis
Copy link
Member

The slider is only valid for the first group. Can you make it like (with text on one row):

image

@YarosMallorca
Copy link
Contributor Author

The slider is only valid for the first group. Can you make it like (with text on one row):

Alright, will do so, how about the one on the right, the D Term, do I make it like that as well, place it below?

@nerdCopter
Copy link
Member

[...] the D Term, do I make it like that as well, place it below?

yes. you could also determine this by changing all filter-settings then review the CLI diff. you will see some settings are # master (profile independent), and some are # profile X (profile dependent).

@haslinghuis
Copy link
Member

haslinghuis commented Feb 22, 2024

#3811 should fix this - as I was fighting with the presentation at the time of implementation it was actually an easy one.

This should have been part of #2638

@haslinghuis
Copy link
Member

Fixed in #3811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

3 participants