Skip to content

Separated "Use Filter Slider" dropdown for clarity #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Separated "Use Filter Slider" dropdown for clarity #3810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4115,6 +4115,9 @@
"pidTuningNonProfileFilterSettings": {
"message": "Profile independent Filter Settings"
},
"pidTuningFilterUseDTermSlider": {
"message": "Use D Term Filter Slider"
},
"pidTuningFilterSlidersHelp": {
"message": "These sliders adjust the Gyro and D-term filters.<br /><br />For more filtering:<br /> - Sliders to left<br> - Lower cutoff frequencies.<br /><br /> Stronger filtering keeps motors cooler by removing more noise, but delays the gyro signal more and may worsen prop-wash or cause resonant oscillations. Less responsive quads eg X-Class do best with stronger filtering. <br><br>For less filtering:<br /> - Sliders to the right<br /> - Higher cutoff frequencies <br><br>Less filtering reduces gyro signal delay, and often improves propwash. Moving the gyro lowpass filter right is usually OK, but moving the D filter to the right is usually not required, and can easily result in very hot motors.",
"description": "Overall helpicon message for filter tuning sliders"
Expand Down Expand Up @@ -4455,6 +4458,9 @@
"pidTuningFilterSettings": {
"message": "Profile dependent Filter Settings"
},
"pidTuningFilterUseGyroSlider": {
"message": "Use Gyro Filter Slider"
},
"pidTuningDTermLowpass": {
"message": "D Term Lowpass 1"
},
Expand Down
4 changes: 3 additions & 1 deletion src/css/tabs/pid_tuning.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@
box-sizing: content-box;
}
}
.cf_column .pid_titlebar tr:first-child {
border-bottom: 1px solid var(--subtleAccent);
}
}
.sliderDivider {
padding: 3px;
Expand All @@ -183,7 +186,6 @@
th {
padding: 5px;
text-align: left;
border-right: 1px solid var(--subtleAccent);
&:first-child {
text-align: left;
border-top-left-radius: 3px;
Expand Down
6 changes: 6 additions & 0 deletions src/tabs/pid_tuning.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,6 +1270,9 @@
<table class="pid_titlebar new_rates">
<tr>
<th i18n="pidTuningNonProfileFilterSettings"></th>
</tr>
<tr>
<th i18n="pidTuningFilterUseGyroSlider"></th>
<td>
<select id="sliderGyroFilterModeSelect" class="sliderMode">
<option value="0" i18n="pidTuningOptionOff"></option>
Expand Down Expand Up @@ -1580,6 +1583,9 @@
<table class="pid_titlebar new_rates">
<tr>
<th i18n="pidTuningFilterSettings"></th>
</tr>
<tr>
<th i18n="pidTuningFilterUseDTermSlider"></th>
<td>
<select id="sliderDTermFilterModeSelect" class="sliderMode">
<option value="0" i18n="pidTuningOptionOff"></option>
Expand Down