Fix GPS tab

[haslinghuis]

• fixes some issues found after 1960bd9

Summary by CodeRabbit

• New Features

  • Improved GPS tab stability by cleaning up the map when closing, reducing memory use and preventing slowdowns.

• Bug Fixes

  • Increased reliability of GPS settings (protocol, baud rate, SBAS) so selections apply consistently.

• Style

  • Updated SBAS control container and label styling for a clearer, more consistent GPS settings UI.

• Refactor

  • Simplified GPS control bindings to match the updated UI structure for easier maintenance.

[coderabbitai]

Walkthrough

Updated GPS tab DOM selectors in JS to match HTML class changes and added a gps.cleanup(callback) method to destroy the map instance and free resources.

Changes

Cohort / File(s)	Change Summary
GPS tab JS selectors & cleanup src/js/tabs/gps.js	Replaced selectors: .number.gps_protocol → .gps_protocol, .number.gps_ubx_sbas → .gps_ubx_sbas (deriving group via closest(".select")), .number.gps_baudrate → .gps_baudrate. Added gps.cleanup(callback) to destroy the map instance and invoke an optional callback.
GPS tab HTML structure src/tabs/gps.html	Changed UBX SBAS control wrapper from div.number.gps_ubx_sbas to div.select; label span changed to span.freelabel while keeping same i18n key and select/options unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as GPS Tab (HTML)
  participant JS as gps.js
  participant Map as Map Instance

  User->>UI: open GPS tab
  UI->>JS: init()
  JS->>Map: create map instance
  Note right of Map: Map initialized

  User->>UI: navigate away / close tab
  UI->>JS: cleanup()
  JS->>Map: destroy()
  JS-->>UI: optional callback()
  Note over JS,Map: resources released

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• 🔧 Update GPS map UI #4563 — modifies gps.js cleanup behavior to destroy the map instance.
• Style: Fix various small UI inconsistencies #4616 — changes GPS tab DOM wrapper classes/selectors in gps.html and corresponding js selector updates.

Suggested labels

RN: UI

Suggested reviewers

• blckmn
• nerdCopter
• VitroidFPV

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	There is no pull request description provided, so the template sections required for context, background, and testing instructions are entirely missing and the generic boilerplate was not replaced with meaningful content.	Please populate the PR description by removing the template instructions and adding sections such as a summary of changes, rationale, and testing steps, following the repository’s description template to aid reviewers.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “Fix GPS tab” directly reflects the main purpose of the changeset by indicating that the GPS tab functionality is being repaired, and it is concise and specific enough for team members to understand at a glance.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b197be and 90e397e.

📒 Files selected for processing (2)

• src/js/tabs/gps.js (1 hunks)
• src/tabs/gps.html (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/tabs/gps.html

🧰 Additional context used

🧬 Code graph analysis (1)

src/js/tabs/gps.js (1)

src/js/tabs/ports.js (1)

• gpsBaudrateElement (164-164)

🔇 Additional comments (2)

src/js/tabs/gps.js (2)

106-117: Selectors now align with the new markup

Switching to the plain .gps_* selectors and using .closest(".select") ensures the handlers and toggles bind to the updated DOM structure so the entire control hides/shows correctly.

---

458-465: Map instance cleanup looks good

Destroying the stored map instance and nulling the reference prevents the OpenLayers objects from lingering after the tab unloads. Thanks for wiring the optional callback as well.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5e676f and 9b197be.

📒 Files selected for processing (2)

• src/js/tabs/gps.js (1 hunks)
• src/tabs/gps.html (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/js/tabs/gps.js (1)

src/js/tabs/ports.js (1)

• gpsBaudrateElement (164-164)

🔇 Additional comments (1)

src/tabs/gps.html (1)

64-69: No CSS selectors reference .gps_ubx_sbas. Search across CSS/LESS yielded zero matches.

[Copilot]

Pull Request Overview

This PR fixes styling and selector issues in the GPS tab to improve reliability and consistency. The changes address UI presentation issues with GPS settings controls and update JavaScript selectors to match the revised HTML structure.

• Updated HTML structure for the GPS SBAS control container and label styling
• Modified JavaScript selectors to align with the new HTML structure
• Improved consistency in GPS settings UI presentation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/tabs/gps.html	Updated SBAS control container class and label styling for better consistency
src/js/tabs/gps.js	Updated JavaScript selectors to match revised HTML structure

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Preview URL: https://pr4633.betaflight-app.pages.dev