Skip to content

Fix GPS tab #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
Merged

Fix GPS tab #4633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86a3a4f
Fix GPS tab
haslinghuis Sep 25, 2025
90e397e
CR I
haslinghuis Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/js/tabs/gps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,17 +103,17 @@ gps.initialize = async function (callback) {
// Introduced in API 1.43
gpsSbas.push(i18n.getMessage("gpsSbasNone"));

const gpsProtocolElement = $(".number.gps_protocol");
const gpsProtocolElement = $(".gps_protocol");
const gpsAutoBaudElement = $('input[name="gps_auto_baud"]');
const gpsAutoBaudGroup = $(".gps_auto_baud");
const gpsAutoConfigElement = $('input[name="gps_auto_config"]');
const gpsAutoConfigGroup = $(".gps_auto_config");
const gpsUbloxGalileoElement = $('input[name="gps_ublox_galileo"]');
const gpsUbloxGalileoGroup = $(".gps_ublox_galileo");
const gpsUbloxSbasElement = $(".number.gps_ubx_sbas");
const gpsUbloxSbasGroup = $(".gps_ubx_sbas");
const gpsUbloxSbasElement = $(".gps_ubx_sbas");
const gpsUbloxSbasGroup = gpsUbloxSbasElement.closest(".select");
const gpsHomeOnceElement = $('input[name="gps_home_once"]');
const gpsBaudrateElement = $(".number.gps_baudrate");
const gpsBaudrateElement = $(".gps_baudrate");

for (let protocolIndex = 0; protocolIndex < gpsProtocols.length; protocolIndex++) {
gpsProtocolElement.append(`<option value="${protocolIndex}">${gpsProtocols[protocolIndex]}</option>`);
Expand Down
4 changes: 2 additions & 2 deletions src/tabs/gps.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@
<span class="freelabel" i18n="configurationGPSHomeOnce"></span>
<div class="helpicon cf_tip" i18n_title="configurationGPSHomeOnceHelp"></div>
</div>
<div class="number gps_ubx_sbas">
<div class="select">
<select class="gps_ubx_sbas">
<!-- list generated here -->
</select>
<span i18n="configurationGPSubxSbas"></span>
<span class="freelabel" i18n="configurationGPSubxSbas"></span>
</div>
</div>
</div>
Expand Down