Skip to content

Automatic event tracking #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Automatic event tracking #1776

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3a3132b
Rough draft for automatic event subscriptions
Mar 27, 2021
a481fcd
Changed EventReader to only have read access to EventSubscriptions
Mar 28, 2021
ede6153
Remove UpdateSubscriberCount command
Mar 28, 2021
fb20d4e
Merge EventSubscriptions into Events
Mar 28, 2021
b69b64a
ManualEventReaders are now obtained from the Events
Mar 28, 2021
401edd5
Change ManualEventReader to match EventReader implementation
Mar 28, 2021
a5ef02d
Some comment changes
Mar 28, 2021
2e39175
Manual event deferral example / test
Mar 28, 2021
9cb4b5f
clippy thing
Mar 28, 2021
53f8810
Remove unnecessary swap
Mar 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/bevy_app/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ bevy_utils = { path = "../bevy_utils", version = "0.4.0" }

# other
serde = { version = "1.0", features = ["derive"] }
parking_lot = "0.11"

[target.'cfg(target_arch = "wasm32")'.dependencies]
wasm-bindgen = { version = "0.2" }
Expand Down
5 changes: 3 additions & 2 deletions crates/bevy_app/src/app_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use crate::{
app::{App, AppExit},
event::Events,
plugin::Plugin,
CoreStage, PluginGroup, PluginGroupBuilder, StartupStage,
CoreStage, EventSubscriptions, PluginGroup, PluginGroupBuilder, StartupStage,
};
use bevy_ecs::{
component::{Component, ComponentDescriptor},
Expand Down Expand Up @@ -228,7 +228,8 @@ impl AppBuilder {
T: Component,
{
self.insert_resource(Events::<T>::default())
.add_system_to_stage(CoreStage::First, Events::<T>::update_system.system())
.insert_resource(EventSubscriptions::<T>::default())
.add_system_to_stage(CoreStage::Last, Events::<T>::update_system.system())
}

/// Inserts a resource to the current [App] and overwrites any resource previously added of the
Expand Down
Loading