Skip to content

Text2d TextBackgroundColor support #20464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 16, 2025
Merged

Text2d TextBackgroundColor support #20464

merged 12 commits into from
Aug 16, 2025

Conversation

ickshonpe
Copy link
Contributor

Objective

Add support for TextBackgroundColor to Text2d.

Solution

Add a TextBackgroundColor query to extract_text2d_sprite and queue a background sprite for each text section with a TextBackgroundColor.

Testing

Added TextBackgroundColors to some of the text in the text2d example:

cargo run --example text2d

Showcase

text2d-background

@ickshonpe ickshonpe added C-Feature A new feature, making something new possible A-Text Rendering and layout for characters M-Needs-Release-Note Work that should be called out in the blog due to impact D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered A-Rendering Drawing game state to the screen labels Aug 8, 2025
@mogambro
Copy link
Contributor

OMG, yes, yes, yes! 😍

@ickshonpe ickshonpe added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 14, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 14, 2025
@alice-i-cecile alice-i-cecile removed the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Aug 14, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 16, 2025
Merged via the queue into bevyengine:main with commit 68aebf3 Aug 16, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Zeophlite Zeophlite Zeophlite approved these changes

@mogambro mogambro mogambro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-Text Rendering and layout for characters C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered M-Needs-Release-Note Work that should be called out in the blog due to impact S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ickshonpe @mogambro @Zeophlite @alice-i-cecile